docs: add fix for m1 macs to readme #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.26% // Head: 74.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 106 106
Lines 2067 2067
Branches 512 512
=======================================
Hits 1535 1535
Misses 504 504
Partials 28 28 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kenclary
approved these changes
Jan 3, 2023
I hope so. If it doesn't work for someone, the github discussion I linked in there should at least give plenty of background information. |
bradenmacdonald
pushed a commit
to open-craft/frontend-app-authoring
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dependency, node-canvas, is not compatible with macs with M1 processors. I fixed this locally based on Automattic/node-canvas#1733. This Pull Requests documents the fix in the README, so others can follow it.