-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ui bugs #542
fix: ui bugs #542
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #542 +/- ##
==========================================
+ Coverage 78.20% 79.48% +1.27%
==========================================
Files 145 145
Lines 2698 2710 +12
Branches 632 636 +4
==========================================
+ Hits 2110 2154 +44
+ Misses 558 526 -32
Partials 30 30
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good, but I found a little problem I think, could you verify whether this appears to you too?
There's a noticable difference in performance. There's already some tiny lag on the master branch for advanced settings, but it get's quite sluggish when you checkout this branch. I switched back and forth between branches a couple of times and I can tell that it's related to something on this branch. At least that's that way on my browser.
I assume we will have to look into the performance graphs of the browser console, do some throttling, and see what's actually happening. I can do some of this as well, though I would like confirmation that it's not just happening on my own machine.
Basically I noticed it when I typed anything in the fields quickly, there was a noticable lag before the input appeared, and it was sluggish and bumpy (type 3 characters quickly and then there's a lag and then all 3 characters appear at once, for example).
I assume this has either something to do with the new transitions, rendering cycle, or maybe a memory leak.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Addressed changes and need to unblock merge
* chore: add paragon messages (openedx#530) * chore: add paragon messages (openedx#530) (openedx#534) Co-authored-by: Mashal Malik <107556986+Mashal-m@users.noreply.github.com> * feat: make placeholder depend on api response * feat: include paragon in atlas pull (openedx#538) This pull request is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification). * fix: ui bugs (openedx#542) --------- Co-authored-by: Mashal Malik <107556986+Mashal-m@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: Omar Al-Ithawi <i@omardo.com> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>
* chore: add paragon messages (openedx#530) * chore: add paragon messages (openedx#530) (openedx#534) Co-authored-by: Mashal Malik <107556986+Mashal-m@users.noreply.github.com> * feat: make placeholder depend on api response * feat: include paragon in atlas pull (openedx#538) This pull request is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification). * fix: ui bugs (openedx#542) --------- Co-authored-by: Mashal Malik <107556986+Mashal-m@users.noreply.github.com> Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com> Co-authored-by: Omar Al-Ithawi <i@omardo.com> Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>
Enable
contentstore.new_studio_mfe.use_new_advanced_settings_page
to view page.Addresses the following issues: