feat: break up load api to tab specific#740
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #740 +/- ##
==========================================
+ Coverage 89.07% 89.21% +0.14%
==========================================
Files 472 474 +2
Lines 7470 7540 +70
Branches 1601 1617 +16
==========================================
+ Hits 6654 6727 +73
+ Misses 788 785 -3
Partials 28 28 ☔ View full report in Codecov by Sentry. |
rayzhou-bit
left a comment
There was a problem hiding this comment.
The change looks great! I think having unit tests for the courses and libraries apis failing similar to the home api would be a good addition.
There are tests for this state in |
Sorry, I see it now. I was searching for |
JIRA Ticket: TNL-11244
This PR is dependent on
edx-platformPR #33909This PR separates the api call for the home page into three parts:
Separating the one api call into these three helps spread out the work on the api and help prevent timeout errors. The PR also adds error messages after each of the api calls so users will know when the api call has failed. Separating out the api will also help developers more easily find and resolve bugs in the loading process.
Testing
homeapi call did not include courses, archived courses, or librariescoursesapi call was successfulhomeapi call, update the url to be invalidcoursesapi was not calledhomeapi url and update thecoursesapi to be invalidcoursesapi and update thelibrariesapi to be invalid