chore(deps): update paragon and frontend-build to openedx scope#818
Conversation
brian-smith-tcril
force-pushed
the
use-openedx-scope
branch
from
ff22705 to
304445e
Compare
| "@edx/react-unit-test-utils": "^2.0.0", | ||
| "@edx/reactifex": "^1.0.3", | ||
| "@edx/stylelint-config-edx": "^2.3.0", | ||
| "@edx/stylelint-config-edx": "2.3.0", |
There was a problem hiding this comment.
this was on 2.3.0 due to the package-lock.json, after rebuilding the package lock to cleanly handle the scope changes it updated to 2.3.3 and caused https://github.com/openedx/frontend-app-course-authoring/actions/runs/7746261151/job/21124075247 to fail with errors such as
src/index.scss
1:9 ✖ Expected ""~@edx/brand/paragon/fonts"" to be "url("~@edx/brand/paragon/fonts")" import-notationPinning it to 2.3.0 prevents those errors.
There was a problem hiding this comment.
No objections. We can deal with that later.
brian-smith-tcril
force-pushed
the
use-openedx-scope
branch
5 times, most recently
from
08ceb04 to
8ae9a9c
Compare
brian-smith-tcril
force-pushed
the
use-openedx-scope
branch
6 times, most recently
from
42b105d to
16720b4
Compare
brian-smith-tcril
force-pushed
the
use-openedx-scope
branch
from
16720b4 to
ae163a8
Compare
| class ResizeObserver { | ||
| observe() { | ||
| // do nothing | ||
| } | ||
|
|
||
| unobserve() { | ||
| // do nothing | ||
| } | ||
|
|
||
| disconnect() { | ||
| // do nothing | ||
| } | ||
| } | ||
|
|
||
| window.ResizeObserver = ResizeObserver; |
There was a problem hiding this comment.
I was getting "ResizeObserver is not defined" errors. I decided to see how paragon is handling those and I found https://github.com/openedx/paragon/blob/7e4a81f9f2350c54362baa852c75dc32c2c2694e/src/setupTest.js#L7-L21, so I copied that here.
brian-smith-tcril
force-pushed
the
use-openedx-scope
branch
3 times, most recently
from
c140298 to
5b4e48b
Compare
brian-smith-tcril
force-pushed
the
use-openedx-scope
branch
from
5b4e48b to
4783c82
Compare
brian-smith-tcril
force-pushed
the
use-openedx-scope
branch
from
29e5244 to
aeb0ee5
Compare
| const { container } = renderComponent(); | ||
| expect(container).toBeEmptyDOMElement(); | ||
| const { queryByTestId } = renderComponent(); | ||
| expect(queryByTestId('browser-router')).toBeEmptyDOMElement(); |
There was a problem hiding this comment.
As of openedx/frontend-platform#615, the AppProvider used in renderComponent includes
<div data-testid="browser-router">and the OptionalReduxProvider in the AppProvider includes
<div data-testid="redux-provider">so instead of the whole container being an empty DOM element, it is
<div data-testid="redux-provider"><div data-testid="browser-router"></div></div>This just updates the test to ensure nothing is rendered inside those divs that are always rendered
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
=======================================
Coverage 89.27% 89.27%
=======================================
Files 551 551
Lines 9738 9738
Branches 2099 2099
=======================================
Hits 8694 8694
Misses 996 996
Partials 48 48 ☔ View full report in Codecov by Sentry. |
arbrandes
left a comment
arbrandes
left a comment
There was a problem hiding this comment.
Congrats on making all tests pasts, and thanks for getting to the bottom of it!
2 participants
No description provided.