Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #122

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Mar 21, 2023

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Mar 21, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft March 21, 2023 09:27
@justinhynes
Copy link
Contributor

Hi @Syed-Ali-Abbas-Zaidi -- this PR has been a draft for a few months now. Is there still work left to do? Can we close this? Thanks for any information on the status of the PR.

If the conflicts are fixed up we can work to prioritize a review of the PR.

@Syed-Ali-Abbas-Zaidi
Copy link
Contributor Author

Hi @Syed-Ali-Abbas-Zaidi -- this PR has been a draft for a few months now. Is there still work left to do? Can we close this? Thanks for any information on the status of the PR.

If the conflicts are fixed up we can work to prioritize a review of the PR.

Hi @justinhynes, This PR will be ready for review once the router upgrade PR of frontend-platform gets merged.

@johnvente
Copy link
Contributor

johnvente commented Aug 3, 2023

Hi! [curious] @Syed-Ali-Abbas-Zaidi, how can I test this in parallel with the [dependency PR]? I've tested it and did't work for me

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ce45c80) 83.01% compared to head (f6c8cfa) 83.01%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          46       46           
  Lines         683      683           
  Branches      132      132           
=======================================
  Hits          567      567           
  Misses        116      116           
Files Changed Coverage Δ
src/index.jsx 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review August 18, 2023 08:40
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@awais-ansari awais-ansari merged commit 2de1299 into master Sep 5, 2023
5 checks passed
@awais-ansari awais-ansari deleted the Ali-Abbas/react-router-upgrade branch September 5, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants