Skip to content

Conversation

@Anas12091101
Copy link
Contributor

@Anas12091101 Anas12091101 commented Sep 17, 2025

This PR updates frontend-component-header to v6.6.x in order to enable support for LearningUserMenuToggleSlot and DesktopUserMenuToggleSlot

@openedx-webhooks
Copy link

Thanks for the pull request, @Anas12091101!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 17, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 17, 2025
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (26099ea) to head (46c0114).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files          47       47           
  Lines         700      700           
  Branches      133      136    +3     
=======================================
  Hits          589      589           
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Anas12091101 Anas12091101 moved this from Needs Triage to Ready for Review in Contributions Sep 17, 2025
@@ -0,0 +1,13 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was adding TS support necessary because of the header bump, or was this done for an independent reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was throwing this error when running the tests:

FAIL src/components/bulk-email-tool/test/BulkEmailTool.test.jsx
  ● Test suite failed to run

    node_modules/@edx/frontend-component-header/dist/studio-header/index.ts:1:26 - error TS6142: Module './StudioHeader' was resolved to '/home/runner/work/frontend-app-communications/frontend-app-communications/node_modules/@edx/frontend-component-header/dist/studio-header/StudioHeader.tsx', but '--jsx' is not set.

    1 import StudioHeader from './StudioHeader';
                               ~~~~~~~~~~~~~~~~

FAIL src/components/page-container/test/PageContainer.test.jsx
  ● Test suite failed to run

    node_modules/@edx/frontend-component-header/dist/studio-header/index.ts:1:26 - error TS6142: Module './StudioHeader' was resolved to '/home/runner/work/frontend-app-communications/frontend-app-communications/node_modules/@edx/frontend-component-header/dist/studio-header/StudioHeader.tsx', but '--jsx' is not set.

    1 import StudioHeader from './StudioHeader';

Similar error was also encountered in the learner dashboard MFE when upgrading the header and then this tsconfig file was added to resolve it. openedx/frontend-app-learner-dashboard#707

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, works for me! Thanks!

auto-merge was automatically disabled September 30, 2025 11:08

Head branch was pushed to by a user without write access

@Anas12091101 Anas12091101 force-pushed the anas/bump-frontend-component-header branch from fe176bb to 46c0114 Compare September 30, 2025 11:08
@arbrandes arbrandes merged commit fa05fa2 into openedx:master Sep 30, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants