-
Notifications
You must be signed in to change notification settings - Fork 55
chore: bump frontend-component-header to v6.6.x #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump frontend-component-header to v6.6.x #254
Conversation
|
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 84.14% 84.14%
=======================================
Files 47 47
Lines 700 700
Branches 133 136 +3
=======================================
Hits 589 589
Misses 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was adding TS support necessary because of the header bump, or was this done for an independent reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was throwing this error when running the tests:
FAIL src/components/bulk-email-tool/test/BulkEmailTool.test.jsx
● Test suite failed to run
node_modules/@edx/frontend-component-header/dist/studio-header/index.ts:1:26 - error TS6142: Module './StudioHeader' was resolved to '/home/runner/work/frontend-app-communications/frontend-app-communications/node_modules/@edx/frontend-component-header/dist/studio-header/StudioHeader.tsx', but '--jsx' is not set.
1 import StudioHeader from './StudioHeader';
~~~~~~~~~~~~~~~~
FAIL src/components/page-container/test/PageContainer.test.jsx
● Test suite failed to run
node_modules/@edx/frontend-component-header/dist/studio-header/index.ts:1:26 - error TS6142: Module './StudioHeader' was resolved to '/home/runner/work/frontend-app-communications/frontend-app-communications/node_modules/@edx/frontend-component-header/dist/studio-header/StudioHeader.tsx', but '--jsx' is not set.
1 import StudioHeader from './StudioHeader';
Similar error was also encountered in the learner dashboard MFE when upgrading the header and then this tsconfig file was added to resolve it. openedx/frontend-app-learner-dashboard#707
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, works for me! Thanks!
Head branch was pushed to by a user without write access
fe176bb to
46c0114
Compare
This PR updates frontend-component-header to v6.6.x in order to enable support for LearningUserMenuToggleSlot and DesktopUserMenuToggleSlot