-
Notifications
You must be signed in to change notification settings - Fork 93
test: Remove support for Node 20 #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Remove support for Node 20 #811
Conversation
|
Thanks for the pull request, @bydawen! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4a39216 to
1cc3c09
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 167 167
Lines 3699 3699
Branches 999 1003 +4
=======================================
Hits 3495 3495
Misses 190 190
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1cc3c09 to
d6931aa
Compare
Description
Complete the upgrade to Node 24 by removing the Node 20 CI check and going back to using
.nvmrcas the source of truth for which version to use.See the tracking issue for further information.