-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow runtime configuration (#253) #282
Conversation
Allows frontend-app-gradebook to be configured at runtime using the LMS's new MFE Configuration API. Part of openedx/wg-frontend#103
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## open-release/olive.master #282 +/- ##
===========================================================
Coverage 100.00% 100.00%
===========================================================
Files 108 110 +2
Lines 1260 1264 +4
Branches 248 248
===========================================================
+ Hits 1260 1264 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a clean cherry-pick from master. +1
@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Allows frontend-app-gradebook to be configured at
runtime using the LMS's new MFE Configuration API.
Part of openedx/wg-frontend#103
TL;DR - [ A short summary of what this PR does and why ]
JIRA: JIRA-XXXX
What changed?
Developer Checklist
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora