[🫒 backport] fix: use getConfig in order to support runtime configuration #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Why does that test fail here, but not in master? Weird. |
|
@arbrandes only because I haven't updated this PR with Ghassan's fix yet 😛 |
kdmccormick
force-pushed
the
open-release/olive.master
branch
from
f92c391 to
30c5b2f
Compare
|
Pushed updated commits, |
kdmccormick
force-pushed
the
open-release/olive.master
branch
from
30c5b2f to
94a5ec4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## open-release/olive.master #287 +/- ##
=============================================================
Coverage ? 100.00%
=============================================================
Files ? 109
Lines ? 1264
Branches ? 248
=============================================================
Hits ? 1264
Misses ? 0
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…#286) Before, gradebook was reading config from `process.env` directly, which locked the app into using only static (build-time) configuration. In order to enable dynamic (runtime) configuration, we update gradebook to use frontend-platform's standard configuration interface: `mergeConfig()` and `getConfig()`. Bumps version from 1.5.0 to 1.6.0. (I would normally just do a patch release for a fix, but the version was hasn't been bumped for a while, so adding in full runtime configuration support seemed like it warranted a proper minor version bump.) Co-authored-by: Ghassan Maslamani <ghassan.maslamani@gmail.com>
kdmccormick
force-pushed
the
open-release/olive.master
branch
from
94a5ec4 to
bdfb2a6
Compare
|
@arbrandes Thanks for the review on the master PR! This one's ready for you too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #286. Please use that PR for details & discussion.