Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't show masters-only columns for courses without a masters track #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Apr 26, 2023

Only show masters-only columns when a course has a master's track.

No Masters track / mode:

Screenshot 2023-05-08 at 3 36 48 PM
Screenshot 2023-05-08 at 3 41 27 PM

Masters track / mode

Screenshot 2023-05-08 at 3 35 49 PM
Screenshot 2023-05-08 at 3 35 55 PM

Note: This is based on TRACKS. As shown in the screenshot above, you can technically have a student who is enrolled as "masters" without a masters track in a course BUT this is only possible through manual developer modification and can't happen in normal user-facing environments.

FYI: @openedx/content-aurora

@jansenk jansenk force-pushed the jkantor/masters-columns branch from fc4bacb to 32be24c Compare May 8, 2023 19:05
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6778948) to head (32be24c).
Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          122       122           
  Lines         1274      1281    +7     
  Branches       250       253    +3     
=========================================
+ Hits          1274      1281    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansenk jansenk marked this pull request as ready for review May 8, 2023 19:44
@jansenk jansenk requested a review from a team as a code owner May 8, 2023 19:44
@farhaanbukhsh farhaanbukhsh changed the title Jkantor/masters columns feat: don't show masters-only columns for courses without a masters track Nov 6, 2024
@farhaanbukhsh
Copy link
Member

@mphilbrick211 This will require a proposal.

@jansenk Are you willing to pursue these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants