feat: use frontend-plugin-framework to provide a FooterSlot #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind taking a look at the tests? Looks like we're running into some related failures. |
brian-smith-tcril
force-pushed
the
footer-slot
branch
from
65fbc7c
to
d4518dd
Compare
|
@arbrandes I pushed a fix for the tests. |
|
Holding off here for a https://github.com/openedx/frontend-slot-footer implementation. |
brian-smith-tcril
force-pushed
the
footer-slot
branch
4 times, most recently
from
9e5234f
to
d8e8e6b
Compare
arbrandes
approved these changes
May 17, 2024
| @@ -24,7 +24,7 @@ const App = () => ( | |||
| /> | |||
| </Routes> | |||
| </main> | |||
| <Footer logo={process.env.LOGO_POWERED_BY_OPEN_EDX_URL_SVG} /> | |||
There was a problem hiding this comment.
Mind also removing the variable from https://github.com/openedx/frontend-app-gradebook/blob/master/.env.development#L10?
There was a problem hiding this comment.
brian-smith-tcril
force-pushed
the
footer-slot
branch
from
d8e8e6b
to
13a19a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This removes the ability to use
LOGO_POWERED_BY_OPEN_EDX_URL_SVGto set the logo in the footer. This was directly usingprocess.envand therefore did not support the more robust configuration methods provided by https://github.com/openedx/frontend-platform/blob/master/src/config.js. The footer component itself supports usingLOGO_TRADEMARK_URLto set the logo (and supports the more robust configuration methods).What changed?
Developer Checklist
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora