-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: max adjusted grades warning and error #402
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @lkatsikaris! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @lkatsikaris, and thank you for this contribution! It looks like you are contributing on behalf of Aulasneo, correct? If so, please have your manager reach out to oscm@axim.org to be added to our existing entity CLA with Aulasneo. |
@mariajgrimaldi is this a new feature, or is this a bugfix? The original issue linked is openedx/wg-build-test-release#357 which implies this is a test failure fix. |
@sarina: the "test failure" issue is labeled as enhancement, so no it's not a bugfix. I will close the test failure issue since the enhancement has already been addressed here. |
Gotcha. This enhancement seems reasonable to me but I'm not sure why all
the dependencies were updated - that shouldn't be a part of the PR.
…On Fri, Oct 18, 2024, 04:37 Maria Grimaldi ***@***.***> wrote:
@sarina <https://github.com/sarina>: the "test failure" issue is labeled
as *enhancement*, so no it's not a bugfix. I will close the test failure
issue since the enhancement has already been addressed here.
—
Reply to this email directly, view it on GitHub
<#402 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPEWJNKJS4YVCP76VN6TVTZ4DCD3AVCNFSM6AAAAABNGCUORWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRRHAZTQMBXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lkatsikaris - can you address comments and remove the updates to the dependency file? And rebase your branch to get the latest updates.
@@ -21,6 +21,11 @@ const messages = defineMessages({ | |||
defaultMessage: 'Reason', | |||
description: 'Edit Modal Override Table Reason column header', | |||
}, | |||
adjustedGradeError: { | |||
id: 'gradebook.GradesView.EditModal.Overrides.adjustedGradeError', | |||
defaultMessage: 'The value exceeds the maximum grade:', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to do string interpolation with the grade value? This won't render properly for some languages, including RTL languages like Arabic
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 94.98% 94.99% +0.01%
==========================================
Files 139 139
Lines 1356 1359 +3
Branches 265 266 +1
==========================================
+ Hits 1288 1291 +3
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. |
@lkatsikaris any updates here? Do you need help? |
32ccae5
to
d0a26cc
Compare
@lkatsikaris you should check why are the snapshots being updated. Is it because of the changes you made or something else? |
Yes, I had to update the snapshots to pass the make test command |
d0a26cc
to
b645d5d
Compare
Fix: message error if the input is greater than the adjusted grade.
Fixes #394
What changed?
Developer Checklist
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora