feat: add career link to user dropdown #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 95.97% 95.75% -0.22%
==========================================
Files 170 165 -5
Lines 1489 1436 -53
Branches 274 255 -19
==========================================
- Hits 1429 1375 -54
- Misses 55 56 +1
Partials 5 5
☔ View full report in Codecov by Sentry. |
This was referenced May 26, 2023
leangseu-edx
approved these changes
May 26, 2023
fix: addressing linter errors chore: update tests snapshot chore: add career link to user dropdown to header variant chore: remove header and rename header variant to be header chore: only enterprise user should see the link chore: only non-enterprise student should see the item feat: upgraded to node v18, added .nvmrc and updated workflows (#151)
leangseu-edx
force-pushed
the
kh/add-career-link-to-user-dropdown
branch
from
23d11b1 to
a86107e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an item to the User Dropdown with the text "Career" and a "New" badge.
This link will only display if the User is NOT an Enterprise user and the
CAREER_LINK_URLvariable is populated.2U Internal Ticket: CAMS-1
