-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add painted door button for no recommendations #198
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
=======================================
Coverage 96.45% 96.46%
=======================================
Files 195 195
Lines 1834 1839 +5
Branches 321 322 +1
=======================================
+ Hits 1769 1774 +5
Misses 60 60
Partials 5 5
☔ View full report in Codecov by Sentry. |
ca828ee
to
1669083
Compare
experimentLoading, | ||
} = usePaintedDoorExperimentContext(); | ||
|
||
const getDefaultOrFailedReturn = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
const getDefaultOrFailedReturn = () => { | |
const getDefaultOrFailedStateWidget = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I had a hard time deciding its name 😅
1669083
to
d42d0cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
VAN-1618
Added Painted door button when there are no recommendations available.