feat: add painted door button for no recommendations #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
=======================================
Coverage 96.45% 96.46%
=======================================
Files 195 195
Lines 1834 1839 +5
Branches 321 322 +1
=======================================
+ Hits 1769 1774 +5
Misses 60 60
Partials 5 5
☔ View full report in Codecov by Sentry. |
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1618
branch
from
ca828ee
to
1669083
Compare
zainab-amir
approved these changes
Aug 24, 2023
| experimentLoading, | ||
| } = usePaintedDoorExperimentContext(); | ||
|
|
||
| const getDefaultOrFailedReturn = () => { |
There was a problem hiding this comment.
nit:
Suggested change
| const getDefaultOrFailedReturn = () => { | |
| const getDefaultOrFailedStateWidget = () => { |
There was a problem hiding this comment.
Thank you! I had a hard time deciding its name 😅
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1618
branch
from
1669083
to
d42d0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VAN-1618
Added Painted door button when there are no recommendations available.