-
Notifications
You must be signed in to change notification settings - Fork 180
feat: add support to hasUnmetPrerequisitesList in CourseBanner #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add support to hasUnmetPrerequisitesList in CourseBanner #760
Conversation
|
Thanks for the pull request, @jignaciopm! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
909f781 to
4f1bd7e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #760 +/- ##
==========================================
+ Coverage 97.54% 97.58% +0.04%
==========================================
Files 148 148
Lines 1302 1327 +25
Branches 224 248 +24
==========================================
+ Hits 1270 1295 +25
Misses 31 31
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jignaciopm Thank you for your contribution! @sarina Looking at #753 and the related openedx/edx-platform#37737, it seems like this would qualify as a clear-scope bug fix from product perspective. I'll ping the product managers team shortly, but let me know if you think this is a special case that won't require product review at all (considering that it's supposed to fix an issue from Ulmo release testing). |
|
Hi @openedx/openedx-product-managers, here's a clear-scope bug fix for you to review. Could one of you please have a look at the changes from this PR and openedx/edx-platform#37737? |
|
This is reviewed & approved by Product; I am awaiting a sandbox which demonstrates the fix before finding a reviewer. |
4f1bd7e to
3d6ae50
Compare
3d6ae50 to
a78ae17
Compare
|
This is approved from a product perspective. @diana-villalvazo-wgu or @jacobo-dominguez-wgu do you have a moment to take a look at this? It feels unlikely we can get it into ulmo.1 but perhaps we can get it in to ulmo.2? |
Description
This pull request enhances the
CourseBannercomponent to provide learners with more detailed feedback when they have unmet prerequisites for a course. Instead of showing a generic message, the banner now lists the specific prerequisite courses with links to their details. The changes also update the related message text and add comprehensive tests to ensure this new functionality works as expected.Improvements to unmet prerequisites banner:
CourseBannercomponent now accepts a new property,hasUnmetPrerequisitesList, fromcoursewareAccess, which contains details about unmet prerequisite courses.Messaging updates:
Testing enhancements:
Supporting information
#753
Testing instructions
First, you need to use edx-platform with this commit, then you can follow the next steps:
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.