Skip to content

Conversation

@feanil
Copy link
Contributor

@feanil feanil commented Sep 23, 2025

Remove @edx/reactifex package from devDependencies as it is no longer
needed. Translation extraction functionality has been verified to work
correctly without this dependency.

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (63e8f49) to head (bbecfed).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files          27       27           
  Lines         443      443           
  Branches      104      102    -2     
=======================================
  Hits          381      381           
  Misses         61       61           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@feanil feanil marked this pull request as ready for review September 25, 2025 14:46
@feanil feanil enabled auto-merge September 25, 2025 14:53
@feanil feanil disabled auto-merge September 25, 2025 18:46
@feanil feanil enabled auto-merge September 25, 2025 19:23
@deborahgu
Copy link
Member

@feanil Here's another one with the required statuses aren't reporting. (The conflict that's getting reported is fake – I've pushed and unconflicted package-lock.json, and I'm wondering if that will show up until all of the other checks have run?)

@brian-smith-tcril
Copy link
Contributor

I'm going to try closing and re-opening this one to see if the checks make more sense after that. If that doesn't work a rebase might.

auto-merge was automatically disabled September 26, 2025 19:04

Pull request was closed

Remove @edx/reactifex package from devDependencies as it is no longer
needed. Translation extraction functionality has been verified to work
correctly without this dependency.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@brian-smith-tcril brian-smith-tcril force-pushed the feanil/remove-reactifex-packages branch from a48fa62 to 2526ed2 Compare September 26, 2025 19:22
Updating package-lock
@brian-smith-tcril brian-smith-tcril force-pushed the feanil/remove-reactifex-packages branch from 2526ed2 to bbecfed Compare September 26, 2025 19:32
@deborahgu deborahgu merged commit bdb05bd into master Sep 26, 2025
7 checks passed
@deborahgu deborahgu deleted the feanil/remove-reactifex-packages branch September 26, 2025 19:36
@brian-smith-tcril
Copy link
Contributor

To get this to work I:

  • Pulled down the branch
  • Rebased on latest master
  • Resolved conflicts by deleting package-lock.json and regenerating
  • Hit strange issues where npm ci worked locally but not on the GH runner or vice versa
  • Upgraded my nvm version of node 20 (ran nvm install 20) from v20.18.1 to v20.19.5 (matching the verison the GH runner was using)
  • Deleted/regenerated package-lock.json again using the newer version of node 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants