fix: prevent content tools from displaying over chat sidebar #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that edx/frontend-lib-learning-assistant#24 should be merged prior to this PR. The version of the library should be updated as part of this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1179 +/- ##
==========================================
- Coverage 87.88% 87.85% -0.04%
==========================================
Files 263 263
Lines 4475 4480 +5
Branches 1129 1132 +3
==========================================
+ Hits 3933 3936 +3
- Misses 528 530 +2
Partials 14 14
☔ View full report in Codecov by Sentry. |
alangsto
force-pushed
the
alangsto/fix_la_with_content_tools
branch
from
5218089 to
8a9dfb7
Compare
|
|
||
| return ( | ||
| <div className="content-tools"> | ||
| {!sidebarIsOpen && ( |
There was a problem hiding this comment.
Nit: Does the parent div needs to be rendered? Or should we hide the entire component?
There was a problem hiding this comment.
I think we could hide the entire component, let me update
michaelroytman
approved these changes
Aug 31, 2023
alangsto
force-pushed
the
alangsto/fix_la_with_content_tools
branch
from
8a9dfb7 to
3e99844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MST-2015
This PR fixes a UI bug when both the learning assistant and content tools are enabled for a course.
When content tools are enabled, they display over the learning assistant toggle:
If the learning sidebar is open, the content tools are similarly displayed over the chat sidebar:
The content tools should be conditionally displayed, depending on whether or not the chat sidebar is open: