Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] feat: add support to paragon design tokens #1203

Closed
wants to merge 1 commit into from
Closed

[DRAFT] feat: add support to paragon design tokens #1203

wants to merge 1 commit into from

Conversation

ghassanmas
Copy link
Member

This PR purpose is to test/demo parago design tokens simliar
to this one for the profile openedx/frontend-app-profile/pull/764

it override the following depns as seen in package.json

Conclousion so far:

  • There is an extra library that learning depends on which needs to support paragon; frontend-lib-learning-assistant and also frontend-lib-special-exams

  • It would be great to have a gudie or a document to look at, while doing the conversion that would map variable from who it was used/named before to the name in design tokens

  • I was stuck in the end with compliation error, that wepack couldn't find Modal exported from paragon.

@ghassanmas
feat: add support to paragon design tokens [wip]
4ead602 
  This PR purpose is to test/demo parago design tokens simliar
  to this one for the profile openedx/frontend-app-profile/pull/764

  it override the following depns as seen in package.json

  - paragon alpha
  - openedx/frontend-build/pull/365
  - openedx/frontend-platform/pull/440
  - openedx/frontend-component-header/pull/351
  - openedx/frontend-component-footer/pull/303

 Conclousion so far:

 - There is an extra library that learning depends on which
  needs to support paragon; `frontend-lib-learning-assistant`
  and also `frontend-lib-special-exams`

 - It would be great to have a gudie or a document to look at,
 while doing the conversion that would **map variable from
 who it was used/named before to the name in design tokens**

 - I was stuck in the end with compliation error, that
 wepack couldn't find `Modal` exported from paragon.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 6, 2023 •
edited
Loading

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@ghassanmas ghassanmas marked this pull request as draft October 6, 2023 08:59
@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 10, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

Thank you for this contribution @ghassanmas! Let us know when the changes are ready for review.

@itsjeyd
Copy link

itsjeyd commented Nov 17, 2023

Hi @ghassanmas! Just a quick update that we're closing this PR for now because it seems to be stale. You can of course reopen this pull request, or open a new one, when you have time to come back to this work.

@itsjeyd itsjeyd closed this Nov 17, 2023
@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added closed inactivity PR was closed because the author abandoned it and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Nov 17, 2023
@ghassanmas
Copy link
Member Author

@itsjeyd this was for demonstration just like this openedx/frontend-app-profile#764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
closed inactivity PR was closed because the author abandoned it core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghassanmas @openedx-webhooks @itsjeyd