course translation waffle flag #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leangseu-edx
force-pushed
the
lk/course-translation-waffle-flag
branch
from
fc74039 to
b953499
Compare
leangseu-edx
requested review from
BrandonHBodine,
Rodra,
hajorg,
jansenk and
nsprenkle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/whole-course-translations #1305 +/- ##
=================================================================
Coverage ? 88.49%
=================================================================
Files ? 297
Lines ? 5008
Branches ? 1260
=================================================================
Hits ? 4432
Misses ? 562
Partials ? 14 ☔ View full report in Codecov by Sentry. |
BrandonHBodine
approved these changes
Feb 29, 2024
BrandonHBodine
left a comment
BrandonHBodine
left a comment
There was a problem hiding this comment.
Left a question but otherwise lgtm.
| showCalculator: data.show_calculator, | ||
| notes: camelCaseObject(data.notes), | ||
| marketingUrl: data.marketing_url, | ||
| language: data.language, |
There was a problem hiding this comment.
Is this referencing the source/original language for the course?
Contributor
Author
There was a problem hiding this comment.
It is just available field for the course overview. TBH, I am not even sure if this would work. Currently it has locale code instead of language code.
There was a problem hiding this comment.
Locale like en-us or locale as in us?
This was referenced Mar 13, 2024
leangseu-edx
added a commit
that referenced
this pull request
Mar 20, 2024
leangseu-edx
added a commit
that referenced
this pull request
Mar 20, 2024
leangseu-edx
added a commit
that referenced
this pull request
Mar 25, 2024
leangseu-edx
added a commit
that referenced
this pull request
Mar 27, 2024
leangseu-edx
added a commit
that referenced
this pull request
Mar 27, 2024
* feat: add language selection chore: update tests so we have less error message test: update test * test: update tests * chore: remove duplicate translation * chore: lint for console * chore: remove comments * chore: make sure the affect url frame refresh after the language selection change * chore: add whole_course_translation and language to courseware meta (#1305) * feat: Add feedback widget UI mock Add unit tests Fix snapshot Clean Sequence component logEvent calls Clean unit test Put feedback widget behind whole course translation flag Fix useFeedbackWidget test * chore: add src and dest translation * feat: first iteration of plugin translation chore: update plugin instruction * feat: Connect FeedbackWidget with backend services (#1325) Connect FeedbackWidget with backend services Move feedback widget to unit translation plugin * feat: Add authentication to WCT feedback endpoints (#1329) * chore: add fetch config and move feedback widget for the plugin chore: rewrite and test the api request chore: rebase chore: update translation feedback chore: test chore: add more tests * chore: rebase * chore: update requested change * chore: update package * chore: upgrade frontend-lib-special-exams and frontend-lib-learning-assistant * chore: update tests * chore: remove unneeded package * chore: update example config * chore: add source-map-loader * fix: feedback widget render error after submit feedback (#1335) * fix: feedback widget render error after submit feedback * fix: widget logic --------- Co-authored-by: Rodrigo Martin <rodrigom_94@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable showing course translation on the flag disabled
Ticket: https://2u-internal.atlassian.net/browse/AU-1858