feat: standardize slot ids #1685
Merged
+369
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-smith-tcril
force-pushed
the
standardize-slot-ids
branch
from
c846b07 to
8a1d9d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1685 +/- ##
==========================================
+ Coverage 90.18% 90.20% +0.01%
==========================================
Files 338 343 +5
Lines 5726 5747 +21
Branches 1379 1381 +2
==========================================
+ Hits 5164 5184 +20
- Misses 543 544 +1
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
added
the
create-sandbox
|
Sandbox deployment successful 🚀 |
arbrandes
approved these changes
Apr 24, 2025
| import { useModel } from '../../../../../../generic/model-store'; | ||
| import { WIDGETS } from '../../../../../../constants'; | ||
| import SidebarContext from '../../../SidebarContext'; | ||
| import { NotificationWidgetSlot } from '../../../../../../plugin-slots/NotificationWidgetSlot'; |
Contributor
There was a problem hiding this comment.
At some point we should look into the @src/... refactor idea. It would make for more readable imports.
Contributor
Author
There was a problem hiding this comment.
Yeah, I just wanted to follow the pattern of the rest of the imports in the file for this one.
nsprenkle
pushed a commit
to edx/frontend-app-learning
that referenced
this pull request
Apr 28, 2025
nsprenkle
added a commit
to edx/frontend-app-learning
that referenced
this pull request
Apr 28, 2025
This reverts commit 045e108.
jciasenza
pushed a commit
to jciasenza/frontend-app-learning
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.