-
Notifications
You must be signed in to change notification settings - Fork 58
test: deprecate react-unit-test-utils part-1 #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @vmnavarro94! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 1078 1078
Branches 160 160
=========================================
Hits 1078 1078 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR deprecates the use of react-unit-test-utils (and its shallow rendering) in favor of react-testing-library for several component tests. Key changes include removing snapshot tests, updating rendering methods, and unmocking necessary modules for proper testing.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/snapshots/StatusBadge.test.jsx.snap | Removed snapshot file |
| src/components/snapshots/ConfirmModal.test.jsx.snap | Removed snapshot file |
| src/components/StatusBadge.test.jsx | Replaced shallow rendering with RTL and updated test logic for status variants |
| src/components/FilePreview/snapshots/FileCard.test.jsx.snap | Removed snapshot file |
| src/components/FilePreview/FileCard.test.jsx | Updated tests to use RTL and proper element queries |
| src/components/FilePopoverContent/index.test.jsx | Replaced shallow rendering with RTL and updated test cases |
| src/components/FilePopoverContent/snapshots/index.test.jsx.snap | Removed snapshot file |
| src/components/DemoAlert/index.test.jsx | Updated RTL tests and added event testing for onClose callback |
| src/components/DemoAlert/snapshots/index.test.jsx.snap | Removed snapshot file |
| src/components/ConfirmModal.test.jsx | Updated tests with RTL and added assertions for modal open/closed states |
Comments suppressed due to low confidence (1)
src/components/StatusBadge.test.jsx:16
- The test uses getByText('FormattedMessage') to find the badge element, which may be too generic and brittle; consider querying for a more specific text or using a test id for reliable selection.
it('`ungraded` shows primary button variant and message', () => {
Co-authored-by: Ayesha Waris <ayesha.waris@192.168.10.31>
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for starting this refactor! Approved!
Description
Remove use of 'shallow' (react-unit-test-utils) in following files, when needed we also removed snapshot to create new unit tests:
Note: As part of this work we find out paragon components were mocked on src/setupTest.jsx causing testing library unit tests to fail, since we are doing this work in multiple PRs and in order to not break other existing snapshot tests, we will unmock paragon or needed things on new tests and by end of react-unit-test-utils removal we will remove paragon mocks and unmock lines accordingly.
Support Information
Closes #425