build: Update codecov and use token #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
=======================================
Coverage 66.78% 66.78%
=======================================
Files 51 51
Lines 849 849
Branches 176 175 -1
=======================================
Hits 567 567
Misses 272 272
Partials 10 10 ☔ View full report in Codecov by Sentry. |
arbrandes
force-pushed
the
update-codecov
branch
2 times, most recently
from
9366aed
to
ecc6991
Compare
.github/workflows/ci.yml
Outdated
| - name: upload coverage | ||
| uses: codecov/codecov-action@v3 | ||
| - name: Coverage | ||
| if: matrix.npm-test == 'test' |
There was a problem hiding this comment.
Suggested change
| if: matrix.npm-test == 'test' | |
| if: ${{ matrix.npm-test == 'test' }} |
I think this is the syntax we need here (just going off of https://docs.github.com/en/actions/learn-github-actions/expressions)
There was a problem hiding this comment.
It seems our wiki was wrong, then. Good catch.
Update codecov to the latest version and start using the org-wide token for uploads. See openedx/wg-frontend#179
arbrandes
force-pushed
the
update-codecov
branch
from
ecc6991
to
2e9dfb9
Compare
justinhynes
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update codecov to the latest version and start using the org-wide token for uploads.
See openedx/wg-frontend#179