Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example changes for test ParagonPlugin #549

Closed
wants to merge 2 commits into from

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented May 28, 2024

This is a complementary PR of #546 to make changes in the example application due to the introduction of paragon and frontend-platform as dependencies.

Should be merged after the base PR

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 28, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 28, 2024

Thanks for the pull request, @dcoa!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-build. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@dcoa dcoa marked this pull request as ready for review May 28, 2024 11:07
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label May 31, 2024
@itsjeyd
Copy link

itsjeyd commented May 31, 2024

Hey @dcoa, thank you for this contribution! It looks like there are some failing tests. Could you have a look at what's happening with those?

@itsjeyd itsjeyd added the blocked by other work PR cannot be finished until other work is complete label May 31, 2024
@dcoa dcoa marked this pull request as draft May 31, 2024 08:34
@dcoa
Copy link
Contributor Author

dcoa commented May 31, 2024

Hi @itsjeyd, I've converted this on the draft understanding that depends on #546 (that's the reason for failing)

@itsjeyd
Copy link

itsjeyd commented Jun 6, 2024

Sounds good, thanks for the info @dcoa.

@itsjeyd
Copy link

itsjeyd commented Sep 7, 2024

Hi @dcoa, it looks like #546 got merged so this PR should no longer be blocked. Is that right? And will you be coming back to work on the changes in the coming days/weeks? If they're no longer needed, let me know so we can close this PR.

@itsjeyd itsjeyd removed the blocked by other work PR cannot be finished until other work is complete label Sep 7, 2024
@dcoa
Copy link
Contributor Author

dcoa commented Sep 10, 2024

Hi @itsjeyd, I closed this PR understanding that the changes was introduced by #584 a few days ago :)

@dcoa dcoa closed this Sep 10, 2024
@itsjeyd
Copy link

itsjeyd commented Sep 20, 2024

Great, thanks @dcoa 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants