-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade frontend-build to v12 #228
Conversation
Codecov ReportBase: 70.27% // Head: 81.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
===========================================
+ Coverage 70.27% 81.25% +10.97%
===========================================
Files 4 4
Lines 37 32 -5
Branches 5 4 -1
===========================================
Hits 26 26
+ Misses 11 6 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…context-values for tests
…t-footer into bilalqamar95/frontend-build-upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! +1
@BilalQamar95, is this still valid? If so, we need to resolve the package-lock conflict. |
…t-footer into bilalqamar95/frontend-build-upgrade
@arbrandes Yes this is still valid, I have resolved the package-lock conflict |
Ticket:
42: Upgrade eslint to v8.x
What changed?
frontend-build
to v12 (Eslint was updated infrontend-build
version resulting in it's version being bumped to v12. This PR updatesfrontend-build
to reciprocate eslint version update)eslint
issues post update