Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to React 17 #230

Closed
wants to merge 1 commit into from
Closed

Conversation

connorhaugh
Copy link

In order to get tests to pass in the https://github.com/openedx/frontend-app-library-authoring/tree/9c2ec1edab14ed1cd1970f858c22dd30f58903f5 Repo, we need to upgrade the footer to use react 17.

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #230 (f050e0a) into master (cf879e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   70.27%   70.27%           
=======================================
  Files           4        4           
  Lines          37       37           
  Branches        5        5           
=======================================
  Hits           26       26           
  Misses         11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arbrandes
Copy link
Contributor

Library-authoring no longer breaks over this, but we probably still want to do it. Might be worth upgrading to the latest point release, though.

@abdullahwaheed
Copy link
Contributor

done in #284. closing this one

@arbrandes arbrandes deleted the feat--update-to-React-17 branch August 1, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants