Skip to content

Conversation

@brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Apr 24, 2025

As of writing, frontend-app-learner-record doesn't use the FooterSlot component, and instead directly wraps the Footer component in a PluginSlot

The id used for that slot by frontend-app-learner-record is "footer_plugin_slot".

By adding "footer_plugin_slot" as an id alias, updating frontend-app-learner-record to use the FooterSlot component can be a non-breaking change.

@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (b2c55a0) to head (d86be35).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files           8        8           
  Lines          63       63           
  Branches       19       19           
=======================================
  Hits           58       58           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections. 👍🏼

@brian-smith-tcril brian-smith-tcril merged commit 3a9e3f8 into openedx:master Apr 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants