FC-0001: Account pages -> micro-frontend #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
needs triage
open-source-contribution
|
Thanks for the pull request, @UvgenGen! I've created OSPR-6653 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
This was referenced May 2, 2022
openedx-webhooks
added
awaiting prioritization
waiting on author
|
@UvgenGen Could you look into the failing CI test? |
UvgenGen
force-pushed
the
depr/account-pages
branch
from
948386f to
ef94583
Compare
|
@natabene Linter error fixed. |
|
@UvgenGen Let's see how tests turn out. |
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 62.58% 62.58%
=======================================
Files 15 15
Lines 278 278
Branches 66 66
=======================================
Hits 174 174
Misses 103 103
Partials 1 1
Continue to review full report at Codecov.
|
|
@arbrandes This is ready for your review. |
openedx-webhooks
added
engineering review
and removed
waiting on author
abdullahwaheed
approved these changes
Oct 12, 2022
27 tasks
30 tasks
36 tasks
28 tasks
BilalQamar95
approved these changes
Dec 2, 2022
arbrandes
approved these changes
Dec 2, 2022
|
@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
ghassanmas
added a commit
to ghassanmas/tutor-mfe
that referenced
this pull request
Apr 25, 2023
frontend-component-header since version v.3.5 requires the the settings of ACCOUNT_SETTINGS_URL to exists as it uses it point to the account MFE. - openedx/frontend-component-header/pull/210 PR that add the setting the componenet - openedx/wg-build-test-release/issues/268 which this fixes
ghassanmas
added a commit
to ghassanmas/tutor-mfe
that referenced
this pull request
May 16, 2023
frontend-component-header since version v.3.5 requires the the settings of ACCOUNT_SETTINGS_URL to exists as it uses it point to the account MFE. - openedx/frontend-component-header/pull/210 PR that add the setting the componenet - openedx/wg-build-test-release/issues/268 which this fixes
ghassanmas
added a commit
to ghassanmas/tutor-mfe
that referenced
this pull request
May 17, 2023
frontend-component-header since version v.3.5 requires the the settings of ACCOUNT_SETTINGS_URL to exists as it uses it point to the account MFE. - openedx/frontend-component-header/pull/210 PR that add the setting the componenet - openedx/wg-build-test-release/issues/268 which this fixes
ghassanmas
added a commit
to ghassanmas/tutor-mfe
that referenced
this pull request
May 17, 2023
frontend-component-header since version v.3.5 requires the the settings of ACCOUNT_SETTINGS_URL to exists as it uses it point to the account MFE. - openedx/frontend-component-header/pull/210 PR that add the setting the componenet - openedx/wg-build-test-release/issues/268 which this fixes
arbrandes
pushed a commit
to overhangio/tutor-mfe
that referenced
this pull request
May 18, 2023
frontend-component-header since version v.3.5 requires the the settings of ACCOUNT_SETTINGS_URL to exists as it uses it point to the account MFE. - openedx/frontend-component-header/pull/210 PR that add the setting the componenet - openedx/wg-build-test-release/issues/268 which this fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added ACCOUNT_PROFILE_URL and ACCOUNT_SETTINGS_URL settings.
edx-platform PR: openedx/edx-platform#30336
frontend-platform PR: openedx/frontend-platform#326
Supporting information
openedx/public-engineering#71
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-17