Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make studio header more flexible #271

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

brian-smith-tcril
Copy link
Contributor

No description provided.

@brian-smith-tcril brian-smith-tcril force-pushed the studio-header-component branch 2 times, most recently from cf60b93 to 2f2b834 Compare October 19, 2022 14:14
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 62.58% // Head: 60.86% // Decreases project coverage by -1.72% ⚠️

Coverage data is based on head (a54f099) compared to base (d529e00).
Patch coverage: 78.26% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   62.58%   60.86%   -1.73%     
==========================================
  Files          15       15              
  Lines         278      299      +21     
  Branches       66       70       +4     
==========================================
+ Hits          174      182       +8     
- Misses        103      115      +12     
- Partials        1        2       +1     
Impacted Files Coverage Δ
src/StudioHeader.jsx 81.81% <78.26%> (-9.85%) ⬇️
src/DesktopHeader.jsx 75.67% <0.00%> (-21.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great, @brian-smith-tcril. Approved.

@arbrandes arbrandes merged commit 6f75684 into openedx:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants