Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20 #150

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 25, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (1f0a0ee) to head (348cac8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files          68       68           
  Lines        1079     1079           
  Branches      295      294    -1     
=======================================
  Hits         1016     1016           
  Misses         58       58           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as draft July 25, 2024 12:55
@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 9, 2024 12:34
@BilalQamar95 BilalQamar95 marked this pull request as draft August 21, 2024 08:43
@BilalQamar95 BilalQamar95 changed the title feat: updated node to v20 build: Upgrade to Node 20 Aug 26, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Aug 26, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review September 5, 2024 08:34
@brian-smith-tcril brian-smith-tcril merged commit a75987f into main Sep 6, 2024
9 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node-v20-upgrade branch September 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants