feat!: major version upgrade of react-router-version to v6 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbrandes
reviewed
Jan 30, 2023
This was referenced Jan 30, 2023
This was referenced Mar 1, 2023
Syed-Ali-Abbas-Zaidi
force-pushed
the
mashal-m/react-router_version_upgrade
branch
3 times, most recently
from
a89c41a
to
d748cda
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 82.98% 83.05% +0.07%
==========================================
Files 40 40
Lines 1040 1062 +22
Branches 187 195 +8
==========================================
+ Hits 863 882 +19
- Misses 165 168 +3
Partials 12 12
☔ View full report in Codecov by Sentry. |
abdullahwaheed
changed the title
Syed-Ali-Abbas-Zaidi
force-pushed
the
mashal-m/react-router_version_upgrade
branch
from
85c90d8
to
6cb9d7e
Compare
|
Let me know when this is ready for a final test/review. |
…shal-m/react-router_version_upgrade
|
@arbrandes its ready to review now |
Syed-Ali-Abbas-Zaidi
force-pushed
the
mashal-m/react-router_version_upgrade
branch
from
904c59a
to
2b4679c
Compare
1 task
abdullahwaheed
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React Router to v6.
BREAKING CHANGES
react-router-domtov6. (Guideline to migrate fromv5tov6)