Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #501

Merged
merged 14 commits into from
Jul 4, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 6, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated paragon to fix react-loading-skeleton issue

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/react-upgrade-to-v17 branch from b9ff8a1 to ee3a2da Compare June 7, 2023 13:02
@Mashal-m Mashal-m force-pushed the bilalqamar95/react-upgrade-to-v17 branch from 836b3ab to dc0f0ba Compare June 13, 2023 12:04
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (67a5783) 83.05% compared to head (8a270e9) 83.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #501   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files          40       40           
  Lines        1062     1062           
  Branches      194      194           
=======================================
  Hits          882      882           
  Misses        168      168           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review July 4, 2023 11:26
@abdullahwaheed abdullahwaheed merged commit d364bbe into master Jul 4, 2023
@abdullahwaheed abdullahwaheed deleted the bilalqamar95/react-upgrade-to-v17 branch July 4, 2023 12:05
@BilalQamar95 BilalQamar95 self-assigned this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants