-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update react & react-dom to v17 #501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BilalQamar95
force-pushed
the
bilalqamar95/react-upgrade-to-v17
branch
from
June 7, 2023 13:02
b9ff8a1
to
ee3a2da
Compare
Mashal-m
force-pushed
the
bilalqamar95/react-upgrade-to-v17
branch
from
June 13, 2023 12:04
836b3ab
to
dc0f0ba
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
=======================================
Coverage 83.05% 83.05%
=======================================
Files 40 40
Lines 1062 1062
Branches 194 194
=======================================
Hits 882 882
Misses 168 168
Partials 12 12 ☔ View full report in Codecov by Sentry. |
…m/openedx/frontend-platform into bilalqamar95/react-upgrade-to-v17
…into bilalqamar95/react-upgrade-to-v17
abdullahwaheed
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React JS to v17
Description
react
&react-dom
to v17enzyme-adapter-react-16
with@wojtekmaj/enzyme-adapter-react-17
paragon
to fix react-loading-skeleton issueMerge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: