-
Notifications
You must be signed in to change notification settings - Fork 79
Make example app compatible with a tutor dev environment #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make example app compatible with a tutor dev environment #819
Conversation
|
Thanks for the pull request, @wgu-taylor-payne! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
bd4b3f4 to
f00e0fa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
=======================================
Coverage 87.12% 87.13%
=======================================
Files 48 48
Lines 1406 1407 +1
Branches 297 300 +3
=======================================
+ Hits 1225 1226 +1
Misses 168 168
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Friendly ping on this @brian-smith-tcril @arbrandes |
|
I initially added specific steps to the README to overcome the CORS related errors, but I thought it might be better to keep it less prescriptive, so I changed that with my "fixup" commit. |
|
@arbrandes @brian-smith-tcril is this worth merging in or, with frontend-base on the horizon, would you rather close this PR? |
@brian-smith-tcril @arbrandes bumping for you :) |
|
Even with the frontend base on the near future I don't think this is harmful in any way and there's still some time before frontend-base it's out there, so given the work is already done, it looks good to me |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a reasonable and desirable change!
I do want to make sure we communicate this out properly. Even with Devstack being deprecated I know it is still being used by some developers. This doesn't require another DEPR, but I want to make sure people that rely on these defaults know they'll need to make changes to their local environments when it lands.
@arbrandes any thoughts on where/how we should communicate this?
Bumping this for you, @arbrandes! |
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Pointed out a typo, though.
I think we should be fine just merging this. This doesn't affect any actual MFE development workflows, and because |
d31a1c6 to
242499b
Compare
Description:
The example app configuration has assumed a devstack dev environment, but devstack has been deprecated in favor of using tutor for dev environments. This PR changes things to work with tutor.
Fixes #811.
Merge checklist:
frontend-platform. This can be done by runningnpm startand opening http://localhost:8080.module.config.jsfile infrontend-build.fix,feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: