chore: remove alias setting and let example use package directly

openedx · Mar 26, 2024 · 8348592 · 8348592
1 parent 273569c
commit 8348592
Show file tree

Hide file tree

Showing 5 changed files with 92 additions and 7 deletions.
diff --git a/example-plugin-app/package-lock.json b/example-plugin-app/package-lock.json
diff --git a/example-plugin-app/webpack.dev.config.js b/example-plugin-app/webpack.dev.config.js
@@ -8,14 +8,14 @@ module.exports = createConfig('webpack-dev', {
       // applications. Because this example app is using code from the parent frontend-plugin-framework
       // library, it runs into the same issues our applications do when loading libraries from
       // local source, rather than from their node_modules directory.
-      '@openedx/frontend-plugin-framework': path.resolve(__dirname, '..', 'src/plugins'),
+      '@openedx/frontend-plugin-framework': path.resolve(__dirname, '..', 'dist'),
       react: path.resolve(__dirname, 'node_modules', 'react'),
       'react-dom': path.resolve(__dirname, 'node_modules', 'react-dom'),
       'react-router-dom': path.resolve(__dirname, 'node_modules', 'react-router-dom'),
     },
   },
   devServer: {
-    port: 8081,
+    port: 8082,
     allowedHosts: 'all',
   },
 });
diff --git a/example/package-lock.json b/example/package-lock.json
diff --git a/example/package.json b/example/package.json
@@ -12,6 +12,7 @@
   "author": "edX",
   "license": "AAGPL-3.0",
   "dependencies": {
+    "@openedx/frontend-plugin-framework": "file:..",
     "core-js": "^3.29.1",
     "prop-types": "^15.8.1",
     "react": "^17.0.0",

diff --git a/example/webpack.dev.config.js b/example/webpack.dev.config.js
@@ -4,11 +4,8 @@ const { createConfig } = require('@openedx/frontend-build');
 module.exports = createConfig('webpack-dev', {
   resolve: {
     alias: {
-      // Note: these four aliases are a manual version of what module.config.js solves in our
-      // applications. Because this example app is using code from the parent frontend-plugin-framework
-      // library, it runs into the same issues our applications do when loading libraries from
-      // local source, rather than from their node_modules directory.
-      '@openedx/frontend-plugin-framework': path.resolve(__dirname, '..', 'src/plugins'),
+      // Note: these 3 aliases are a manual version of what module.config.js solves in our
+      // applications.
       react: path.resolve(__dirname, 'node_modules', 'react'),
       'react-dom': path.resolve(__dirname, 'node_modules', 'react-dom'),
       'react-router-dom': path.resolve(__dirname, 'node_modules', 'react-router-dom'),