Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow pulling unreviewed entries when running $ i18n_tool transifex pull #96

Open
OmarIthawi opened this issue Apr 7, 2021 · 0 comments

Comments

@OmarIthawi
Copy link
Member

What this helps

This allows fork maintainers to chose whether to pull unreviewed entries or not. Currently it's hardcoded:

https://github.com/edx/i18n-tools/blob/95897b0126380ea4ac6dabd422862067102bc152/i18n/transifex.py#L56-L60

User story

  • As a fork maintainer, I would like to pull the release resources (e.g. Koa) and including unreviewed entires.

What about i18n_tool pull_all?

This command would work, but it doesn't allow to specifiy which resource to pull.

Root cause: review status gone missing for release resources

The root cause of this issue is that when release files are made, they're often marked in bulk as "unreviewed" instead of copying the "reviewed" status from the "master" Transifex resources.

OmarIthawi added a commit to appsembler/edx-platform that referenced this issue Apr 7, 2021
without this fix i18n_robot_pull would only pull reviewed entries which
is a problem since release translations are not reviewed:

 - openedx/i18n-tools#96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant