Skip to content

feat: Add context_key property to library collection/container keys#378

Closed
bradenmacdonald wants to merge 1 commit intoopenedx:masterfrom
open-craft:braden/context_key
Closed

feat: Add context_key property to library collection/container keys#378
bradenmacdonald wants to merge 1 commit intoopenedx:masterfrom
open-craft:braden/context_key

Conversation

@bradenmacdonald
Copy link
Contributor

Any key for a content item (e.g. an XBlock, a container, a collection) that's in a library or course should have the .context_key property to get the key of the learning context (course or library) that contains it.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 23, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.77%. Comparing base (15ae68c) to head (a5bb183).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
opaque_keys/edx/keys.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   93.84%   93.77%   -0.08%     
==========================================
  Files          31       31              
  Lines        3007     3021      +14     
  Branches      192      192              
==========================================
+ Hits         2822     2833      +11     
- Misses        159      161       +2     
- Partials       26       27       +1     
Flag Coverage Δ
unittests 93.77% <96.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bradenmacdonald
Copy link
Contributor Author

Closing in favor of #379

@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Apr 23, 2025
@bradenmacdonald bradenmacdonald deleted the braden/context_key branch April 29, 2025 01:25
@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants