Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEP 0029: Real Time Theming (Draft) #80

Conversation

taranjeet
Copy link

It adds guidelines to allow updating theme dynamically and develop features that will allow to apply any theme from Open edX interface.

It is based on the following document

Note: As OpenCraft, our role is to define a proper solution and ensure that the future developments move in the right direction, but not committing on developing any of this at the moment.

@openedx-webhooks
Copy link

Thanks for the pull request, @taranjeet! I've created OSPR-2599 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Sep 6, 2018
@mduboseedx
Copy link

@taranjeet Thanks for the proposal. Let me know me this is ready for a discussion and review.

@taranjeet
Copy link
Author

Sure @mduboseedx I will let you know when its ready for an edx review.

oeps/oep-0029-arch-real-time-theming.rst Outdated Show resolved Hide resolved
oeps/oep-0029-arch-real-time-theming.rst Outdated Show resolved Hide resolved
oeps/oep-0029-arch-real-time-theming.rst Outdated Show resolved Hide resolved
oeps/oep-0029-arch-real-time-theming.rst Outdated Show resolved Hide resolved
Copy link

@mtyaka mtyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but otherwise this looks good to me, thanks!

oeps/oep-0029-arch-near-real-time-theming.rst Outdated Show resolved Hide resolved
@taranjeet
Copy link
Author

@mtyaka Thanks for the review. I have addressed all your concerns.
@mduboseedx : It is ready for an edx review.

@mduboseedx
Copy link

@edx/arch-review Could you take a look at this OEP proposal about Real Time Theming?

@mtyaka
Copy link

mtyaka commented Oct 22, 2018

Thanks @mduboseedx. Any idea when we can expect a review?

@mduboseedx
Copy link

@edx/arch-review @nasthagiri Do you know who might be a good person to look over this OEP?

@natabene natabene requested a review from nasthagiri October 26, 2018 17:19
@nasthagiri
Copy link
Contributor

@taranjeet @mtyaka Thank you for making progress on this OEP. Please see my comment on the other Theming-related OEP and the suggestion to keep this in Draft form until early next year.

@natabene
Copy link

@nasthagiri @ormsbee Is it a good time to pick this up again ?

@nasthagiri
Copy link
Contributor

nasthagiri commented Feb 22, 2019

@natabene Please see my comment on the other Theming-related OEP. Thanks.

@natabene
Copy link

@nasthagiri Thank you for your comment, super helpful to me.

@natabene natabene added blocked by other work PR cannot be finished until other work is complete and removed needs triage labels Feb 22, 2019
@openedx-webhooks openedx-webhooks added needs triage and removed blocked by other work PR cannot be finished until other work is complete labels May 21, 2019
@openedx openedx deleted a comment from openedx-webhooks May 29, 2019
@nasthagiri
Copy link
Contributor

@taranjeet I am closing this proposed OEP since we have not had traction on this effort. We can reopen if/when there is further interest in this direction.

Also, we will be revisiting theming as we venture into MFE deployments for Open edX.

@openedx-webhooks openedx-webhooks added blocked by other work PR cannot be finished until other work is complete rejected and removed blocked by other work PR cannot be finished until other work is complete labels Sep 4, 2020
@openedx-webhooks
Copy link

@taranjeet Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants