-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OEP 0029: Real Time Theming (Draft) #80
OEP 0029: Real Time Theming (Draft) #80
Conversation
Thanks for the pull request, @taranjeet! I've created OSPR-2599 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
@taranjeet Thanks for the proposal. Let me know me this is ready for a discussion and review. |
Sure @mduboseedx I will let you know when its ready for an edx review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, but otherwise this looks good to me, thanks!
@mtyaka Thanks for the review. I have addressed all your concerns. |
@edx/arch-review Could you take a look at this OEP proposal about Real Time Theming? |
Thanks @mduboseedx. Any idea when we can expect a review? |
@edx/arch-review @nasthagiri Do you know who might be a good person to look over this OEP? |
@taranjeet @mtyaka Thank you for making progress on this OEP. Please see my comment on the other Theming-related OEP and the suggestion to keep this in Draft form until early next year. |
@nasthagiri @ormsbee Is it a good time to pick this up again ? |
@natabene Please see my comment on the other Theming-related OEP. Thanks. |
@nasthagiri Thank you for your comment, super helpful to me. |
@taranjeet I am closing this proposed OEP since we have not had traction on this effort. We can reopen if/when there is further interest in this direction. Also, we will be revisiting theming as we venture into MFE deployments for Open edX. |
@taranjeet Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
It adds guidelines to allow updating theme dynamically and develop features that will allow to apply any theme from Open edX interface.
It is based on the following document
Note: As OpenCraft, our role is to define a proper solution and ensure that the future developments move in the right direction, but not committing on developing any of this at the moment.