-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sourceSets dir fallback #335
fix: sourceSets dir fallback #335
Conversation
Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@volodymyr-chekyrta A better solution would be to introduce a new flag with the default value |
a5da067
to
93818c0
Compare
@HamzaIsrar12, I was thinking about this option too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer THEME_DIRECTORY
because it covers fonts, drawables, views etc
93818c0
to
ea0132e
Compare
ea0132e
to
3980a15
Compare
Makes sense 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for this much-needed PR! 😄
@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Backport of sourceSets dir fallback (#335)
This PR introduces a fallback for the sourceSets directory.
This fallback is aimed at fixing an issue with the Tutor build.
Config: