Bug: List the public libraries in library list

[MaferMazu]

Description

If a library is public, it should be visible to everyone.

How to reproduce it

1. Register or enter in the ulmo sandbox.
2. Enter in studio, you could use this page: https://apps.ulmo.demo.edly.io/authoring/libraries
3. You don't see libraries available.

Expected behavior: See the libraries with public access.

(Note: for this test, I created https://apps.ulmo.demo.edly.io/authoring/library/lib:Axim:public-lib-01 with public access)

Related code

• https://github.com/eduNEXT/edx-platform/blob/release/ulmo/openedx/core/djangoapps/content_libraries/api/libraries.py#L816
• [FC-0099] feat: filter libraries based on user-role scopes openedx-platform#37564

Related ulmo test

(TC-00421) https://docs.google.com/spreadsheets/d/1-gEXI4IiAn5mdROGDMxNcFHAaZCRu3mxVLNDmTdJFI8/edit?pli=1&gid=1705224758#gid=1705224758

[MaferMazu]

I tested again, and I was able to see the public libraries! I'll run a few tests tomorrow to make sure everything works, and if it does, I'll close this.

[MaferMazu]

Yes, this is working as expected. The filter list is using the following criteria to show libraries:

perms[CAN_VIEW_THIS_CONTENT_LIBRARY] = is_user_active & (
    # Global staff can access any library
    is_global_staff |
    # Libraries with "public read" permissions can be accessed only by course creators
    (Attribute('allow_public_read', True) & is_course_creator) |
    # Users can access libraries within their authorized scope (via Casbin/role-based permissions)
    HasPermissionInContentLibraryScope(VIEW_LIBRARY) |
    # Fallback to: the user must be part of the library's team (legacy permission system)
    has_explicit_read_permission_for_library
)

https://github.com/openedx/edx-platform/blob/release/ulmo/openedx/core/djangoapps/content_libraries/permissions.py#L237

I put in the description of this issue:

If a library is public, it should be visible to everyone.

But it's not true. Libraries with "public read" permissions can be accessed only by course creators.

And it makes sense because a regular user (for example, a student) shouldn't be able to see the libraries.

---

I'll close this issue, but tagging @gviedma-aulasneo for visibility.