fix: handle block.xml content properly#419
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| raise ValueError("learning_package_id must be set before resolving static files.") | ||
| text_content = contents_api.get_or_create_text_content( | ||
| self.learning_package_id, | ||
| contents_api.get_or_create_media_type("application/xml").id, |
There was a problem hiding this comment.
We use a custom media type per block type. We're going to have to refactor this later, but for now please use the same one we do here:
That is to say, f"application/vnd.openedx.xblock.v1.{block_type}+xml"
There was a problem hiding this comment.
So a <problem> block's OLX gets application/vnd.openedx.xblock.v1.problem+xml
There was a problem hiding this comment.
This is done. I apologize for the late change requests, and I really appreciate your support
There was a problem hiding this comment.
No worries! Thank you for all the crunch work. Merged and published v0.29.1 of the package.
No description provided.