Skip to content

Comments

fix: handle block.xml content properly#419

Merged
ormsbee merged 4 commits intoopenedx:mainfrom
WGU-Open-edX:dwong2708/special_handling_block_xml
Oct 23, 2025
Merged

fix: handle block.xml content properly#419
ormsbee merged 4 commits intoopenedx:mainfrom
WGU-Open-edX:dwong2708/special_handling_block_xml

Conversation

@dwong2708
Copy link
Contributor

No description provided.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 23, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 23, 2025

Thanks for the pull request, @dwong2708!

This repository is currently maintained by @axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@dwong2708 dwong2708 requested a review from ormsbee October 23, 2025 01:42
@dwong2708 dwong2708 marked this pull request as ready for review October 23, 2025 01:42
raise ValueError("learning_package_id must be set before resolving static files.")
text_content = contents_api.get_or_create_text_content(
self.learning_package_id,
contents_api.get_or_create_media_type("application/xml").id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use a custom media type per block type. We're going to have to refactor this later, but for now please use the same one we do here:

https://github.com/openedx/edx-platform/blob/067ca72ed02a2316945d77d045fe85d5b9d3c3bd/openedx/core/djangoapps/content_libraries/api/blocks.py#L656-L658

That is to say, f"application/vnd.openedx.xblock.v1.{block_type}+xml"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So a <problem> block's OLX gets application/vnd.openedx.xblock.v1.problem+xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done. I apologize for the late change requests, and I really appreciate your support

Copy link
Contributor

@ormsbee ormsbee Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Thank you for all the crunch work. Merged and published v0.29.1 of the package.

@dwong2708 dwong2708 requested a review from ormsbee October 23, 2025 05:21
@ormsbee ormsbee merged commit 0ac3994 into openedx:main Oct 23, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants