Skip to content

Commit

Permalink
fix: addressing PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mariajgrimaldi committed May 7, 2021
1 parent 43d3e0b commit b53c1f8
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions openedx_filters/exceptions.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
"""
Exceptions thrown by Hooks.
Exceptions thrown by filters.
"""


class HookFilterException(Exception):
"""
Base exception for hooks.
Base exception for filters.
It is re-raised by the Pipeline Runner if any filter that is
executing raises it.
Expand Down
2 changes: 1 addition & 1 deletion openedx_filters/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def run_pipeline(trigger_name, *args, **kwargs):
out (dict): accumulated outputs of the functions defined in pipeline.
result (obj): return object of one of the pipeline functions. This will
be the returned by the pipeline if one of the functions returns
an object different than Dict o None.
an object different than Dict or None.
Exceptions raised:
HookFilterException: custom exception re-raised when a function raises
Expand Down
2 changes: 1 addition & 1 deletion openedx_filters/tests/test_pipeline.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""
Tests for `edx-django-utils` hooks pipeline.
Tests for pipeline runner used by filters.
"""
from unittest.mock import Mock, patch

Expand Down
4 changes: 2 additions & 2 deletions openedx_filters/tests/test_utils.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""
Tests for the `edx-django-utils` hooks utilities.
Tests for utilities used by the filters tooling.
"""
from unittest.mock import patch

Expand All @@ -18,7 +18,7 @@ def test_function():
@ddt.ddt
class TestUtilityFunctions(TestCase):
"""
Test class to verify standard behavior of hooks utility functions.
Test class to verify standard behavior of utility functions.
"""

def test_get_empty_function_list(self):
Expand Down

0 comments on commit b53c1f8

Please sign in to comment.