Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add upgrade python requirements bot #51

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

mariajgrimaldi
Copy link
Member

Description:
This PR adds a github action which opens a PR updating python requirements in a weekly manner tagging the hooks-extension-framework team as reviewers.

Reference: openedx/openedx-events#106

Github issue
#40

Merge deadline:
As soon as possible.

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@openedx-webhooks openedx-webhooks added core committer open-source-contribution PR author is not from Axim or 2U labels Dec 1, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @mariajgrimaldi!

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.


on:
schedule:
- cron: "0 0 * * 1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work if we go with H 0 * * 1 to avoid peaks of execution right at the 0 minute?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using the same schedule for openedx-events, can we keep it? for consistency

Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would work brilliantly. If you can address my comment about the cron time, it would be great. If it does not work I think is fair to merge as it currently is.

@mariajgrimaldi mariajgrimaldi merged commit 96da9f8 into main Dec 5, 2022
@mariajgrimaldi mariajgrimaldi deleted the MJG/reqs-bot-setup branch December 5, 2022 09:49
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core committer open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants