feat: Added a filter for modifying the course home url for externally hosted courses #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfanuddinahmad
changed the title
irfanuddinahmad
force-pushed
the
iahmad/ENT-7164
branch
2 times, most recently
from
413f7d6
to
dec50cf
Compare
irfanuddinahmad
changed the title
irfanuddinahmad
force-pushed
the
iahmad/ENT-7164
branch
3 times, most recently
from
9596a58
to
df653ed
Compare
irfanuddinahmad
force-pushed
the
iahmad/ENT-7164
branch
from
df653ed
to
8e6d2c8
Compare
felipemontoya
approved these changes
May 25, 2023
There was a problem hiding this comment.
Thanks @irfanuddinahmad. I think this looks good and is ready to be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a filter for modifying the course home url for externally hosted courses
Reference
The URL will flow downstream to both the B2B and B2C learner dashboards. B2B enterprise-course-enrollments API gets the course_home_url via another B2C helper function get_course_run_url in edx-platform (source) whereas the B2C learner home init API calls course_home_url directly (source).
Reviewers:
Merge checklist:
Post merge:
finished.