-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __init__.py to harmony_search #67
Conversation
Without this, the module does not get installed correctly when installing the package with pip.
Thanks for the pull request, @mtyaka! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtyaka Could you please bump the version number in the __about__.py
?
I set it to 0.5.1 to match the value in charts/harmony-chart/Chart.yaml.
@gabor-boros Done. I set it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtyaka I updated the version number to be 0.2.0
instead of 0.5.1
. Although I see the point of having matching version numbers, the plugin is basically separate from the chart, it is just shipped in the same repo as the chart. I'm going to quickly approve and merge this change, so we reduce the back and forth.
@mtyaka 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Without this, the module does not get installed correctly when installing the package with pip.
Test instructions:
pip install "git+https://github.com/openedx/openedx-k8s-harmony.git@harmony-chart-0.5.1#egg=tutor-contrib-harmony-plugin&subdirectory=tutor-contrib-harmony-plugin"
harmony_search
module:from tutor_k8s_harmony_plugin.harmony_search.base import BaseSearchAPI
; you will get an import errorpip uninstall -y tutor-contrib-harmony-plugin && pip install "git+https://github.com/open-craft/openedx-k8s-harmony.git@mtyaka/add-init-files#egg=tutor-contrib-harmony-plugin&subdirectory=tutor-contrib-harmony-plugin"
from tutor_k8s_harmony_plugin.harmony_search.base import BaseSearchAPI