Skip to content

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Oct 19, 2023

Description

Configure the lookup_value_regex in the TaxonomyView. Currently, accessing the API using an invalid pk (i.e. using a str) throws an exception when the value is converted to int, returning status 500, instead of a 404.

Testing instructions

  1. Please ensure that the tests cover the expected behavior of the view
  2. Using this branch, run the dev server: python manage.py runserver
  3. Create a superuser using python manage.py createsuperuser
  4. Login in admin and authenticate with the user created (http://127.0.0.1:8000/admin)
  5. In the same browser session, check the result in the API Viewer:

Private-ref: FAL-3529

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 19, 2023

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 19, 2023
@rpenido rpenido marked this pull request as ready for review October 20, 2023 17:05
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido 👍

  • I tested this: I followed the testing instructions
  • I read through the code and considered the security, stability and performance implications of the changes.
  • Includes tests for bugfixes and/or features added.

@rpenido
Copy link
Contributor Author

rpenido commented Oct 20, 2023

Thank you @ChrisChV!

@bradenmacdonald, could you do a CC review here?

@rpenido rpenido force-pushed the rpenido/taxonomy-rest-api-add-lookup-value-regex branch from bc59f7e to cc8de55 Compare October 20, 2023 21:20
@bradenmacdonald bradenmacdonald merged commit be5d527 into openedx:main Oct 23, 2023
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the rpenido/taxonomy-rest-api-add-lookup-value-regex branch October 23, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants