-
Notifications
You must be signed in to change notification settings - Fork 18
refactor: tag_object param order #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: tag_object param order #165
Conversation
|
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Hi @bradenmacdonald ! This is a small fix that I made when I was developing openedx/modular-learning#180. |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you ❤️
|
Does this break anything in edx-platform though? Will we have to make corresponding changes on that side before bumping the version? |
No. All calls from |
|
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR changes the param order in the
tag_contentfunction and the tests accordingly.PS: all function calls at
edx-platformuse named parameters, so this PR doesn't impact there.Testing Instructions
Private ref: FAL-3621