Skip to content

Conversation

@pomegranited
Copy link
Contributor

@pomegranited pomegranited commented Jul 29, 2024

Description

Adds support for fetching the most recent PublishLog for a given Component, by querying the relevant PublishLogRecords.

Testing instructions

See openedx/edx-platform#35195 for full testing instructions.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 29, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 29, 2024

Thanks for the pull request, @pomegranited!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @axim-engineering. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Adds freezegun to the test requirements so we can check published_at dates.
@pomegranited
Copy link
Contributor Author

Hi @ormsbee :) When you get a chance, could you have a look at the approach I took here and let me know if there's anything I should change?

@pomegranited pomegranited force-pushed the jill/get_last_publish_log_for_entity branch from d94eb83 to e7dddad Compare July 30, 2024 22:26
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work @pomegranited !

  • I tested this using the instructions from openedx/edx-platform#35195
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It's working well @pomegranited, great work!

  • I tested this: Followed testing instructions in openedx/edx-platform#35195
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@pomegranited pomegranited merged commit d2e5e3b into main Jul 31, 2024
@openedx-webhooks
Copy link

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants