-
Notifications
You must be signed in to change notification settings - Fork 18
feat: get_last_publish log for PublishableEntity [FC-0059] #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @pomegranited! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Adds freezegun to the test requirements so we can check published_at dates.
|
Hi @ormsbee :) When you get a chance, could you have a look at the approach I took here and let me know if there's anything I should change? |
d94eb83 to
e7dddad
Compare
rpenido
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work @pomegranited !
- I tested this using the instructions from openedx/edx-platform#35195
- I read through the code
- I checked for accessibility issues
- Includes documentation
yusuf-musleh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 It's working well @pomegranited, great work!
- I tested this: Followed testing instructions in openedx/edx-platform#35195
- I read through the code
-
I checked for accessibility issues - Includes documentation
|
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Adds support for fetching the most recent PublishLog for a given Component, by querying the relevant PublishLogRecords.
Testing instructions
See openedx/edx-platform#35195 for full testing instructions.