test: add collections app to import linter config #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All new apps should have an entry in the .importlinter config file so that our internal dependency tree stays clean, but we don't actually document that anywhere yet. Made openedx#230 to track work around making a "new app" checklist doc to help with this sort of thing in the future.
|
@pomegranited, @navinkarkera, @rpenido: Just wanted you folks to be aware that this import-linting exists (I completely forgot to mention it during my review of the collections app). |
navinkarkera
approved these changes
Sep 19, 2024
bradenmacdonald
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All new apps should have an entry in the .importlinter config file so that our internal dependency tree stays clean, but we don't actually document that anywhere yet.
Made #230 to track work around making a "new app" checklist doc to help with this sort of thing in the future.