-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add collections support for containers [FC-0083] #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add collections support for containers [FC-0083] #299
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
0eab0e1 to
ca8a355
Compare
74f0d91 to
1145b22
Compare
1145b22 to
66d0d17
Compare
pomegranited
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This is working great, thank you @rpenido ! I have suggested a couple other places where we can make things simpler/quicker, open for discussion.
- I tested this while testing openedx/frontend-app-authoring#1797
- I read through the code
-
I checked for accessibility issues by using my keyboard to navigateN/A - Updates documentation
-
User-facing strings are extracted for translationN/A
Co-authored-by: Jillian <jill@opencraft.com>
8e38604 to
595a032
Compare
Description
This PR adds support for adding Containers to Collections.
We moved the
set_collectionsmethod fromComponents APItoCollections APIto use it with Containers.Also, we replaced some
Componenttypes to make it more generic and accept other types ofPublishableEntitiesSupporting information
Testing instructions
Private ref: FAL-4111