Skip to content

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Apr 8, 2025

Description

This PR adds support for adding Containers to Collections.
We moved the set_collections method from Components API to Collections API to use it with Containers.
Also, we replaced some Component types to make it more generic and accept other types of PublishableEntities

Supporting information

Testing instructions


Private ref: FAL-4111

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 8, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 8, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@rpenido rpenido force-pushed the rpenido/fal-4111/move-set-collections-api branch from 0eab0e1 to ca8a355 Compare April 8, 2025 19:54
@rpenido rpenido changed the title refactor: move set_collection function to make it generic refactor: move set_collection function to make it generic [FC-0083] Apr 8, 2025
@rpenido rpenido changed the title refactor: move set_collection function to make it generic [FC-0083] feat: add collections support for containers [FC-0083] Apr 9, 2025
@rpenido rpenido force-pushed the rpenido/fal-4111/move-set-collections-api branch 3 times, most recently from 74f0d91 to 1145b22 Compare April 10, 2025 14:55
@rpenido rpenido closed this Apr 10, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Apr 10, 2025
@rpenido rpenido reopened this Apr 10, 2025
@rpenido rpenido force-pushed the rpenido/fal-4111/move-set-collections-api branch from 1145b22 to 66d0d17 Compare April 10, 2025 15:55
@rpenido rpenido marked this pull request as ready for review April 10, 2025 23:47
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is working great, thank you @rpenido ! I have suggested a couple other places where we can make things simpler/quicker, open for discussion.

  • I tested this while testing openedx/frontend-app-authoring#1797
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate N/A
  • Updates documentation
  • User-facing strings are extracted for translation N/A

rpenido and others added 2 commits April 11, 2025 20:24
@pomegranited pomegranited merged commit 9eadbc1 into openedx:main Apr 15, 2025
11 checks passed
@rpenido rpenido deleted the rpenido/fal-4111/move-set-collections-api branch April 15, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants