Skip to content

Conversation

@dwong2708
Copy link
Contributor

@dwong2708 dwong2708 commented Jul 8, 2025

Description

Fixes: #337

This PR updates the lp_dump management command to export real data from the LearningPackage model instead of using stub values.

Acceptance Criteria

  • Give an error in the lp_dump command if the export process fails
  • Export actual data from the LearningPackage model instead of stub values

Example of the content:

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 8, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 8, 2025

Thanks for the pull request, @dwong2708!

This repository is currently maintained by @axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Updates the lp_dump management command to export real data from the LearningPackage model instead of using stub values
@dwong2708 dwong2708 force-pushed the dwong2708/lp_dump_real_data branch from 1f74b56 to 000c9fa Compare July 8, 2025 22:16
@dwong2708 dwong2708 marked this pull request as ready for review July 8, 2025 22:27
@dwong2708 dwong2708 requested a review from ormsbee July 8, 2025 22:27
Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small requests.

@dwong2708 dwong2708 requested a review from ormsbee July 10, 2025 19:21
Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your follow-up PR, please add tests for this functionality (and the new stuff involving PublishableEntities).

@ormsbee ormsbee merged commit 293f20f into openedx:main Jul 10, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Export LearningPackage Data in lp_dump

3 participants