-
Notifications
You must be signed in to change notification settings - Fork 18
feat: export LearningPackage data in lp_dump command #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export LearningPackage data in lp_dump command #338
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Updates the lp_dump management command to export real data from the LearningPackage model instead of using stub values
1f74b56 to
000c9fa
Compare
ormsbee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small requests.
openedx_learning/apps/authoring/backup_restore/management/commands/lp_dump.py
Outdated
Show resolved
Hide resolved
openedx_learning/apps/authoring/backup_restore/management/commands/lp_dump.py
Outdated
Show resolved
Hide resolved
openedx_learning/apps/authoring/backup_restore/management/commands/lp_dump.py
Outdated
Show resolved
Hide resolved
openedx_learning/apps/authoring/backup_restore/management/commands/lp_dump.py
Show resolved
Hide resolved
ormsbee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For your follow-up PR, please add tests for this functionality (and the new stuff involving PublishableEntities).
Description
Fixes: #337
This PR updates the
lp_dumpmanagement command to export real data from theLearningPackagemodel instead of using stub values.Acceptance Criteria
lp_dumpcommand if the export process failsLearningPackagemodel instead of stub valuesExample of the content: