Skip to content

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Jun 29, 2023

Documenting the decision to move from using openedx-filters to openedx-events

See openedx/modular-learning#78 for more information.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 29, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 29, 2023

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rpenido rpenido marked this pull request as ready for review June 29, 2023 12:32
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @rpenido ! Couple of nits to fix on wording, but I agree it's the right way to go here.

@ormsbee Do you agree?

👍

  • I read through the code and rendered documentation
  • Commit structure follows OEP-0051

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 3, 2023
@rpenido rpenido force-pushed the rpenido/fal-3424-implement-content-event-signals branch from 39bbf2e to eecd4e4 Compare July 3, 2023 18:37
@rpenido
Copy link
Contributor Author

rpenido commented Jul 3, 2023

Fixing wording and squashing commits

@pomegranited pomegranited merged commit a5b109f into openedx:main Jul 4, 2023
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@pomegranited pomegranited deleted the rpenido/fal-3424-implement-content-event-signals branch July 4, 2023 01:30
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants